Improve handling LDBODY array sizes in tests - #321
Merged
Conversation
The sizes of LDBODY arrays are not known at compile-time, so ERFA C functions require the size to be passed as a separate argument. The ufunc wrappers can look up array sizes at runtime, so they do not have that argument. Therefore, when `erfa_generator` translates ERFA C tests to Python the array size arguments must be removed. So far that has been done by replacing sub-strings in the C source code, but that required making assumptions about variable names and literal values. Now the removal is performed without those assumptions.
avalentino
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sizes of LDBODY arrays are not known at compile-time, so ERFA C functions require the size to be passed as a separate argument. The ufunc wrappers can look up array sizes at runtime, so they do not have that argument. Therefore, when
erfa_generatortranslates ERFA C tests to Python the array size arguments must be removed. On currentmainthis is done by replacing sub-strings in the C source code, but that requires making assumptions about variable names and literal values. In this PR the removal is performed without those assumptions.